Skip to content

chore: convert functions to an ES2015 classes #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2024
Merged

chore: convert functions to an ES2015 classes #1656

merged 2 commits into from
Apr 13, 2024

Conversation

hasanalkaf3
Copy link
Contributor

@hasanalkaf3 hasanalkaf3 commented Apr 7, 2024 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • [ ✅ ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ ✅ ] I have read CONTRIBUTING.md.
  • [ ✅ ] This pull request is all my own work -- I have not plagiarized.
  • [ ✅ ] I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ✅ ] All new JavaScript files are placed inside an existing directory.
  • [ ✅ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ✅ ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ✅ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor. In general, please try to get rid of the enclosing functions as well. Classes that are unnecessarily "nested" inside functions are confusing.

@hasanalkaf3 hasanalkaf3 requested a review from appgurueu April 8, 2024 22:05
appgurueu
appgurueu approved these changes Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decent improvement as-is.

@raklaptudirm raklaptudirm merged commit 6fe21d2 into TheAlgorithms:master Apr 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasanalkaf3 @appgurueu @raklaptudirm